Skip to content

Add eslint#35

Merged
rekmarks merged 4 commits intomasterfrom
lint
Aug 20, 2020
Merged

Add eslint#35
rekmarks merged 4 commits intomasterfrom
lint

Conversation

@rekmarks
Copy link
Copy Markdown
Member

@rekmarks rekmarks commented Aug 19, 2020

  • Add eslint, @metamask/eslint-config, and relevant plugins
  • Lint
    • Package updates and lint:fix were applied in 50fc181
    • Manual rule fixes were applied in c8d62c3 for ease of review
  • Notes on rules
    • no-mixed-operators is disabled for now to lessen the review burden; it can be enabled later.
    • We should probably just continue to disable prefer-destructuring for arrays and no-bitwise.

@rekmarks rekmarks requested a review from a team as a code owner August 19, 2020 23:23
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whymarrh
Copy link
Copy Markdown
Contributor

  • We should probably just continue to disable prefer-destructuring for arrays [...]

I've created MetaMask/eslint-config#57 to update the base config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants