This repository was archived by the owner on Nov 9, 2023. It is now read-only.
fix: race issue in stream processing#47
Merged
Gudahtt merged 2 commits intoMetaMask:mainfrom Jun 14, 2023
Merged
Conversation
Gudahtt
previously approved these changes
Jun 14, 2023
Member
Gudahtt
left a comment
There was a problem hiding this comment.
LGTM! Great catch. I wasn't able to understand the linked issue in detail, but regardless this seems like a sensible change.
Gudahtt
approved these changes
Jun 14, 2023
8 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Uniswap/interface#6613 by resolving a race condition with
ReadableStreampipes: initialized pipes may process data synchronously, but uninitialized pipes will process data asynchronously (only after being initialized). This can manifest in any dApp that MetaMask runs on as a hanging stream, and unresponsive MetaMask provider.