This repository was archived by the owner on Nov 9, 2023. It is now read-only.
Merged
Conversation
1e4d971 to
406a395
Compare
Contributor
Author
|
The build is red as PR is marginally missing the threshold for test coverage. I have test covered the functionality already. |
This was referenced Oct 21, 2022
naugtur
reviewed
Oct 24, 2022
src/createStreamMiddleware.ts
Outdated
| if (!context) { | ||
| throw new Error(`StreamMiddleware - Unknown response id "${res.id}"`); | ||
| console.warn(`StreamMiddleware - Unknown response id "${res.id}"`); | ||
| return; |
Contributor
There was a problem hiding this comment.
(could) Document why this is just a warning, not an error with a long comment
naugtur
reviewed
Oct 24, 2022
naugtur
previously approved these changes
Oct 24, 2022
Contributor
|
Question: Should we respond with an error instead of failing silently if we run out of retries? I believe we should. |
Co-authored-by: Zbyszek Tenerowicz <naugtur@gmail.com>
…ddleware-stream into request_retry_count
Gudahtt
reviewed
Oct 26, 2022
Gudahtt
reviewed
Oct 26, 2022
Gudahtt
reviewed
Oct 27, 2022
Member
Gudahtt
left a comment
There was a problem hiding this comment.
LGTM! One remaining lint error but then I can approve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR has following changes, in context of DAPP action replay for MV3:
request.idisundefined,undefinedis valid value ofrequest.id.