Skip to content

Revert babel 7#32

Merged
legobeat merged 3 commits intoMetaMask:mainfrom
legobeat:revert-babel-7
Nov 23, 2023
Merged

Revert babel 7#32
legobeat merged 3 commits intoMetaMask:mainfrom
legobeat:revert-babel-7

Conversation

@legobeat
Copy link
Copy Markdown

@legobeat legobeat commented Nov 22, 2023


Blocking

@legobeat legobeat marked this pull request as ready for review November 22, 2023 23:09
@socket-security
Copy link
Copy Markdown

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
babel-plugin-transform-es3-property-literals 6.5.0 eval +2 1.32 MB hzoo
babel-plugin-transform-es3-member-expression-literals 6.5.0 eval +2 1.32 MB hzoo
babel-register 6.18.0 eval, filesystem, environment +31 3.36 MB hzoo
babel-plugin-transform-es2015-unicode-regex 6.11.0 eval, filesystem +9 2.55 MB hzoo
babel-plugin-transform-es2015-sticky-regex 6.8.0 eval, filesystem +6 2.48 MB hzoo
babel-plugin-transform-es2015-literals 6.8.0 eval, filesystem +3 2.34 MB hzoo
babel-plugin-transform-es2015-shorthand-properties 6.18.0 eval, filesystem +5 2.48 MB hzoo
babel-cli 6.18.0 eval, filesystem +43 4.05 MB hzoo
babel-plugin-transform-es2015-function-name 6.9.0 eval, filesystem +19 3.02 MB hzoo
babel-core 6.18.2 eval, filesystem, environment +31 3.36 MB hzoo
babel-plugin-check-es2015-constants 6.8.0 eval, filesystem +3 2.34 MB hzoo
babel-plugin-transform-es2015-arrow-functions 6.8.0 eval, filesystem +3 2.34 MB hzoo
babel-plugin-transform-es2015-block-scoped-functions 6.8.0 eval, filesystem +3 2.34 MB hzoo
babel-plugin-transform-es2015-object-super 6.8.0 eval, filesystem +19 3.02 MB hzoo
babel-plugin-transform-es2015-parameters 6.18.0 eval, filesystem +20 3.03 MB hzoo
babel-plugin-transform-es2015-destructuring 6.19.0 eval, filesystem +3 2.35 MB hzoo
babel-plugin-transform-es2015-block-scoping 6.18.0 eval, filesystem +17 3.03 MB hzoo
babel-plugin-transform-es2015-for-of 6.18.0 eval, filesystem +3 2.34 MB hzoo
babel-plugin-transform-es2015-spread 6.8.0 eval, filesystem +3 2.34 MB hzoo
babel-plugin-transform-es2015-template-literals 6.8.0 eval, filesystem +3 2.34 MB hzoo
babel-plugin-transform-es2015-computed-properties 6.8.0 eval, filesystem +20 3.03 MB hzoo
babel-plugin-transform-es2015-modules-commonjs 6.18.0 eval, filesystem +18 3.03 MB hzoo
babel-plugin-transform-es2015-classes 6.18.0 eval, filesystem +22 3.06 MB hzoo
babel-plugin-transform-object-rest-spread 6.19.0 eval, filesystem +4 2.35 MB hzoo
lint-staged 1.0.1 shell +14 173 kB okonet
babel-eslint 7.1.0 eval, filesystem +17 3.11 MB hzoo
rimraf 3.0.2...2.3.4 None +2/-0 128 kB isaacs
eslint-plugin-react 7.33.2...5.1.1 None +0/-129 223 kB yannickcr
eslint-config-airbnb 17.1.1...9.0.1 None +65/-152 6.78 MB ljharb
pre-commit 1.2.2...1.1.3 None +3/-1 64.3 kB 3rdeden
mocha 7.2.0...5.2.0 None +7/-95 1.12 MB boneskull
bignumber.js 9.1.2...3.0.1 None +0/-0 252 kB mikemcl
babel-loader 8.3.0...6.2.8 filesystem, environment +60/-66 6.84 MB danez
chai 4.3.10...3.5.0 None +3/-6 421 kB chaijs
eslint-plugin-jsx-a11y 6.8.0...1.2.0 None +0/-132 369 kB evcohen
eslint-plugin-import 2.29.0...1.8.0 None +61/-115 6.12 MB benmosher
eslint 5.16.0...2.10.1 None +49/-58 5.58 MB ivolodin

🚮 Removed packages: @babel/cli@7.23.0, @babel/core@7.23.2, @babel/eslint-parser@7.22.15, @babel/plugin-transform-arrow-functions@7.22.5, @babel/plugin-transform-block-scoped-functions@7.22.5, @babel/plugin-transform-block-scoping@7.23.0, @babel/plugin-transform-classes@7.22.15, @babel/plugin-transform-computed-properties@7.22.5, @babel/plugin-transform-destructuring@7.23.0, @babel/plugin-transform-for-of@7.22.15, @babel/plugin-transform-function-name@7.22.5, @babel/plugin-transform-literals@7.22.5, @babel/plugin-transform-member-expression-literals@7.22.5, @babel/plugin-transform-modules-commonjs@7.23.0, @babel/plugin-transform-object-rest-spread@7.22.15, @babel/plugin-transform-object-super@7.22.5, @babel/plugin-transform-parameters@7.22.15, @babel/plugin-transform-property-literals@7.22.5, @babel/plugin-transform-shorthand-properties@7.22.5, @babel/plugin-transform-spread@7.22.5, @babel/plugin-transform-sticky-regex@7.22.5, @babel/plugin-transform-template-literals@7.22.5, @babel/plugin-transform-unicode-regex@7.22.5, @babel/register@7.22.15

@socket-security
Copy link
Copy Markdown

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Bin script confusion ganache-cli 6.12.2
Bin script shell injection ganache-cli 6.12.2
Bin script confusion semver 5.7.2
Bin script confusion which 1.2.14
Bin script confusion which 1.3.1
Bin script confusion sha.js 2.4.11
Critical CVE minimist 0.0.8
Mild CVE minimist 0.0.8
Critical CVE loader-utils 0.2.17
New author loader-utils 0.2.17
CVE minimatch 2.0.10
Deprecated minimatch 2.0.10
  • Reason: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
CVE shelljs 0.6.1
Mild CVE shelljs 0.6.1
Deprecated cross-spawn-async 2.2.5
  • Reason: cross-spawn no longer requires a build toolchain, use it instead
Deprecated babel-eslint 7.1.0
  • Reason: babel-eslint is now @babel/eslint-parser. This package will no longer receive updates.
Deprecated chokidar 1.7.0
  • Reason: Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
Deprecated circular-json 0.3.3
  • Reason: CircularJSON is in maintenance only, flatted is its successor.
Deprecated mkdirp 0.5.1
  • Reason: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
Deprecated core-js 1.2.7
  • Reason: core-js@<3.4 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Please, upgrade your dependencies to the actual version of core-js.
No README core-js 1.2.7
Deprecated core-js 2.6.12
  • Reason: core-js@<3.4 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Please, upgrade your dependencies to the actual version of core-js.
Mild CVE ajv 4.11.8
Mild CVE yargs-parser 4.2.1
New author babel-plugin-transform-es3-member-expression-literals 6.5.0
New author babel-plugin-transform-es3-property-literals 6.5.0
New author babel-messages 6.23.0
New author doctrine 1.2.3
New author jsonify 0.0.1
  • New Author: ljharb
  • Previous Author:
New author babel-loader 6.2.8
New author component-emitter 1.3.1
Unstable ownership component-emitter 1.3.1
No README eslint-plugin-react 5.1.1
No README jsesc 1.3.0
No README output-file-sync 1.1.2
Shell access staged-git-files 0.0.4

Next steps

What is bin script confusion?

This package has multiple bin scripts with the same name. This can cause non-deterministic behavior when installing or could be a sign of a supply chain attack

Consider removing one of the conflicting packages. Packages should only export bin scripts with their name

What is bin script shell injection?

This package re-exports a well known shell command via an npm bin script. This is possibly a supply chain attack

Packages should not export bin scripts which conflict with well known shell commands

What is a critical CVE?

Contains a Critical Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

What is a mild CVE?

Contains a low severity Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known low severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is a CVE?

Contains a high severity Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known high severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

What is a deprecated package?

The maintainer of the package marked it as deprecated. This could indicate that a single version should not be used, or that the package is no longer maintained and any new vulnerabilities will not be fixed.

Research the state of the package and determine if there are non-deprecated versions that can be used, or if it should be replaced with a new, supported solution.

Why are READMEs important?

Package does not have a README. This may indicate a failed publish or a low quality package.

Add a README to to the package and publish a new version.

What is unstable ownership?

A new collaborator has begun publishing package versions. Package stability and security risk may be elevated.

Try to reduce the amount of authors you depend on to reduce the risk to malicious actors gaining access to your supply chain. Packages should remove inactive collaborators with publishing rights from packages on npm.

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore minimatch@2.0.10
  • @SocketSecurity ignore shelljs@0.6.1
  • @SocketSecurity ignore minimist@0.0.8
  • @SocketSecurity ignore ajv@4.11.8
  • @SocketSecurity ignore yargs-parser@4.2.1
  • @SocketSecurity ignore core-js@1.2.7
  • @SocketSecurity ignore core-js@2.6.12
  • @SocketSecurity ignore eslint-plugin-react@5.1.1
  • @SocketSecurity ignore jsesc@1.3.0
  • @SocketSecurity ignore output-file-sync@1.1.2
  • @SocketSecurity ignore babel-plugin-transform-es3-member-expression-literals@6.5.0
  • @SocketSecurity ignore babel-plugin-transform-es3-property-literals@6.5.0
  • @SocketSecurity ignore babel-messages@6.23.0
  • @SocketSecurity ignore doctrine@1.2.3
  • @SocketSecurity ignore loader-utils@0.2.17
  • @SocketSecurity ignore jsonify@0.0.1
  • @SocketSecurity ignore babel-loader@6.2.8
  • @SocketSecurity ignore component-emitter@1.3.1
  • @SocketSecurity ignore cross-spawn-async@2.2.5
  • @SocketSecurity ignore babel-eslint@7.1.0
  • @SocketSecurity ignore chokidar@1.7.0
  • @SocketSecurity ignore circular-json@0.3.3
  • @SocketSecurity ignore mkdirp@0.5.1
  • @SocketSecurity ignore staged-git-files@0.0.4
  • @SocketSecurity ignore ganache-cli@6.12.2
  • @SocketSecurity ignore semver@5.7.2
  • @SocketSecurity ignore which@1.2.14
  • @SocketSecurity ignore which@1.3.1
  • @SocketSecurity ignore sha.js@2.4.11

This was referenced Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants