Skip to content
This repository was archived by the owner on Oct 7, 2024. It is now read-only.

Rename dispose to destroy#179

Merged
mikesposito merged 1 commit intomainfrom
chore/rename-dispose-in-destroy
Jun 15, 2023
Merged

Rename dispose to destroy#179
mikesposito merged 1 commit intomainfrom
chore/rename-dispose-in-destroy

Conversation

@mikesposito
Copy link
Copy Markdown
Member

@mikesposito mikesposito commented Jun 15, 2023

This PR renames the dispose method to destroy, to make it aligned with the Ledger keyring.

Changes

  • BREAKING: dispose method has been renamed to destroy

References

@mikesposito mikesposito requested a review from a team as a code owner June 15, 2023 11:32
Gudahtt
Gudahtt approved these changes Jun 15, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt mentioned this pull request Jun 15, 2023
Merged
@mikesposito mikesposito merged commit e08206a into main Jun 15, 2023
@mikesposito mikesposito deleted the chore/rename-dispose-in-destroy branch June 15, 2023 16:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Gudahtt Gudahtt Gudahtt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rename Trezor's dispose method to destroy

2 participants

@mikesposito @Gudahtt