This repository was archived by the owner on Oct 7, 2024. It is now read-only.
Merged
Conversation
brunobar79
suggested changes
Feb 28, 2019
Contributor
brunobar79
left a comment
There was a problem hiding this comment.
@szymonlesisz Thank you for this PR! Looks good just two nits and we can merge it.
package.json
Outdated
| "events": "^2.0.0", | ||
| "hdkey": "0.8.0", | ||
| "trezor-connect": "^6.0.2" | ||
| "trezor-connect": "7.0.1" |
Contributor
There was a problem hiding this comment.
Can you add back the ^ ?
index.js
Outdated
| this.paths = {} | ||
| this.deserialize(opts) | ||
| TrezorConnect.manifest({ | ||
| email: 'support@metamask.io', |
Contributor
There was a problem hiding this comment.
Would you mind moving these two as const at to the top of the file ?
Contributor
Author
|
Sure thing, it's there as requested |
brunobar79
approved these changes
Mar 1, 2019
Contributor
|
Thank you @szymonlesisz ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I would like to ask you to update trezor-connect version to 7.0.1
There were some major changes in ethereum protobuf messages in new Trezor firmware (1.8.0/2.1.0) and connect@6 will probably fail on "signTransaction" and "getAddress" methods.
There is also a new, required method "manifest" which needs to be added. We would like you to provide a contact to reach you in case of any required maintenance.
you can read more here:
https://github.com/trezor/connect/blob/develop/docs/index.md#trezor-connect-manifest