Remove properties eth,contract,provider from TokenTracker class#121
Merged
legobeat merged 2 commits intoMetaMask:mainfrom Apr 22, 2024
Merged
Remove properties eth,contract,provider from TokenTracker class#121legobeat merged 2 commits intoMetaMask:mainfrom
legobeat merged 2 commits intoMetaMask:mainfrom
Conversation
68284c7 to
b3e1560
Compare
b3e1560 to
93407c2
Compare
93407c2 to
b7a1359
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The props
eth,contractandproviderdon't seem to actually be used or needed anywhere (including inmetamask-extension). This removes these properties.As they are still part of the public interface, this is a breaking change.
Removed
eth,contract,providerfromTokenTrackerclassBlocked by