Skip to content

deps: Replace ethjs packages with @metamask/ forks#115

Merged
legobeat merged 2 commits intoMetaMask:mainfrom
legobeat:deps-metamask-ethjs
Nov 29, 2023
Merged

deps: Replace ethjs packages with @metamask/ forks#115
legobeat merged 2 commits intoMetaMask:mainfrom
legobeat:deps-metamask-ethjs

Conversation

@legobeat
Copy link
Copy Markdown
Contributor

@legobeat legobeat commented Nov 21, 2023

  • Replace ethjs with bn.js - it was only used for re-export
  • ethjs-contract@^0.2.3 -> @metamask/ethjs-contract@^0.3.1
  • ethjs-query@0.3.8 -> @metamask/ethjs-query@^0.5.0

@legobeat legobeat added the dependencies Pull requests that update a dependency file label Nov 21, 2023
@socket-security
Copy link
Copy Markdown

socket-security bot commented Nov 21, 2023

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/ethjs-contract 0.3.4 environment +3 1.3 MB
@metamask/ethjs-query 0.5.2 environment +3 1.44 MB lgbot
bn.js 4.12.0 None +0 95.7 kB fanatid

🚮 Removed packages: ethjs@0.4.0, ethjs-contract@0.2.3, ethjs-query@0.3.8

- Replace ethjs with bn.js - it was only used for re-export
- ethjs-contract@^0.2.3 -> @metamask/ethjs-contract@^0.3.1
- ethjs-query@0.3.8 -> @metamask/ethjs-query@^0.5.0
@legobeat legobeat force-pushed the deps-metamask-ethjs branch from 75c71ed to e5aa483 Compare November 21, 2023 05:18
@legobeat legobeat marked this pull request as ready for review November 21, 2023 05:20
@legobeat legobeat requested a review from a team as a code owner November 21, 2023 05:20
@legobeat legobeat requested review from a team November 22, 2023 00:29
@legobeat legobeat requested a review from a team November 29, 2023 02:48
@socket-security
Copy link
Copy Markdown

socket-security bot commented Nov 29, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @metamask/ethjs-contract@0.3.4

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat legobeat requested a review from danjm November 29, 2023 02:49
@legobeat
Copy link
Copy Markdown
Contributor Author

@SocketSecurity ignore @metamask/ethjs-contract@0.3.4

Copy link
Copy Markdown
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@legobeat legobeat merged commit 8e9405c into MetaMask:main Nov 29, 2023
@legobeat
Copy link
Copy Markdown
Contributor Author

Looks good.

Thanks! RC: #116

@legobeat legobeat deleted the deps-metamask-ethjs branch November 29, 2023 23:58
@legobeat legobeat restored the deps-metamask-ethjs branch November 29, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants