Skip to content
This repository was archived by the owner on Oct 7, 2024. It is now read-only.

chore(deps): replace superstruct imports with @metamask/superstruct#311

Merged
danroc merged 8 commits intomainfrom
replace-superstruct-with-fork
Jul 18, 2024
Merged

chore(deps): replace superstruct imports with @metamask/superstruct#311
danroc merged 8 commits intomainfrom
replace-superstruct-with-fork

Conversation

@MajorLift
Copy link
Copy Markdown
Contributor

@MajorLift MajorLift commented May 30, 2024 •
edited
Loading

Explanation

As part of the Wallet Framework Team's OKR (Q2 2024 O3KR4) for upgrading TypeScript to v5.0+ in the core monorepo, we are updating dependencies of the core repo so that they generate builds and type declarations for both CJS and ESM.

This requirement applies to nested dependencies as well, so we are also replacing superstruct with the ESM-compatible fork @metamask/superstruct in all core dependency packages.

Description

  • Replace superstruct dependency with @metamask/superstruct ^3.0.0.
    • ^3.1.0
  • Replace all superstruct import statements with @metamask/superstruct
  • Bump @metamask/utils to ^8.5.0.
    • ^9.1.0
  • If feasible without too much additional work:
  • Using the create-release-pr github action, publish a new release containing these changes.

References

Changelog

## [4.3.2]
### Changed
- Bump `@metamask/eth-sig-util` from `^7.0.1` to `^7.0.3`. ([#311](https://github.com/MetaMask/eth-snap-keyring/pull/311))
- Bump `@metamask/keyring-api` from `^8.0.0` to `^8.0.1`. ([#311](https://github.com/MetaMask/eth-snap-keyring/pull/311))
- Bump `@metamask/snaps-controllers` from `^4.2.0` to `^9.2.0`. ([#311](https://github.com/MetaMask/eth-snap-keyring/pull/311))
- Bump `@metamask/snaps-sdk` from `^4.2.0` to `^6.0.0`. ([#311](https://github.com/MetaMask/eth-snap-keyring/pull/311))
- Bump `@metamask/snaps-utils` from `^7.4.0` to `^7.7.0`. ([#311](https://github.com/MetaMask/eth-snap-keyring/pull/311))
- Bump `@metamask/utils` from `^8.4.0` to `^9.1.0` ([#311](https://github.com/MetaMask/eth-snap-keyring/pull/311))

### Fixed
- Replace `superstruct` with ESM-compatible `@metamask/superstruct` `^3.1.0` ([#311](https://github.com/MetaMask/eth-snap-keyring/pull/311))
  - This fixes the issue of this package being unusable by any TypeScript project that uses `Node16` or `NodeNext` as its `moduleResolution` option.

Loading
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@danroc danroc danroc approved these changes

@mcmire mcmire mcmire left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@MajorLift MajorLift

Labels

team-wallet-framework

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Regression from setting tsconfig option moduleResolution to NodeNext Replace superstruct with ESM-compatible fork @metamask/superstruct

3 participants

@MajorLift @mcmire @danroc