This repository was archived by the owner on Oct 7, 2024. It is now read-only.
Conversation
a52293d to
efe32ae
Compare
Merged
The `wallets` property of the keyring has been renamed to `_wallets`, to communicate that it is meant to be private and is not part of the public API. The tests have also been updated to avoid using any internal methods or properties.
efe32ae to
892c17d
Compare
shanejonas
approved these changes
Jul 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
walletsproperty of the keyring has been renamed to_wallets, to communicate that it is meant to be private and is not part of the public API.The tests have also been updated to avoid using any internal methods or properties.