This repository was archived by the owner on Oct 7, 2024. It is now read-only.
Always return rejected Promise upon failure#85
Merged
Conversation
f0ab248 to
e1e6e2c
Compare
shanejonas
previously approved these changes
Jul 12, 2021
All methods that return Promises now use the `async` keyword. This simplifies the methods and ensures a consistent return value in the case of an error. For example, the method `getAppKeyAddress` would sometimes reject if it encountered an error, and sometimes it would throw an error. Now it will always reject, which is what you would typically expect of an asynchronous function.
e1e6e2c to
3b1764c
Compare
Member
Author
|
Just rebased this to resolve the conflicts |
shanejonas
approved these changes
Jul 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All methods that return Promises now use the
asynckeyword. This simplifies the methods and ensures a consistent return value in the case of an error.For example, the method
getAppKeyAddresswould sometimes reject if it encountered an error, and sometimes it would throw an error. Now it will always reject, which is what you would typically expect of an asynchronous function.