This repository was archived by the owner on Oct 7, 2024. It is now read-only.
Make version-specific signTypedData methods private#84
Merged
Conversation
cb3995a to
dc66aa4
Compare
c14af0a to
a3e6b20
Compare
Member
Author
|
Rebased to resolve conflicts Edit: Rebased to resolve conflicts again |
The methods for a specific version of `signTypedData` are now private. The `signTypedData` method accepts an `options` parameter that allows using a specific version, and in practice this is the only method called in MetaMask anyway.
a3e6b20 to
7acf8b9
Compare
The `opts` parameter for the version-specific `signTypedData` functions is now guaranteed to be truthy, because the functions are now private and only called internally. The default value for `opts` has been removed to improve our unit test branch coverage.
rekmarks
approved these changes
Jul 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The methods for a specific version of
signTypedDataare now private. ThesignTypedDatamethod accepts anoptionsparameter that allows using a specific version, and in practice this is the only method called in MetaMask anyway.