Skip to content
This repository was archived by the owner on Oct 7, 2024. It is now read-only.

Make getPrivateKeyFor a private method#83

Merged
Gudahtt merged 2 commits intomainfrom
make-get-private-key-for-method-private
Jul 12, 2021
Merged

Make getPrivateKeyFor a private method#83
Gudahtt merged 2 commits intomainfrom
make-get-private-key-for-method-private

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Jul 8, 2021

This method appears to have been introduced for internal use. It has been made private, as we already have a method for exporting the private key (exportAccount).

@Gudahtt Gudahtt requested a review from a team as a code owner July 8, 2021 22:52
This method appears to have been introduced for internal use. It has
been made private, as we already have a method for exporting the
private key (`exportAccount`).
@Gudahtt Gudahtt force-pushed the make-get-private-key-for-method-private branch from 7efc4d3 to e22d3ff Compare July 9, 2021 01:21
Copy link
Copy Markdown
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit d12a814 into main Jul 12, 2021
@Gudahtt Gudahtt deleted the make-get-private-key-for-method-private branch July 12, 2021 18:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants