This repository was archived by the owner on Oct 7, 2024. It is now read-only.
upgrades ethereumjs-wallet which drops scrypt#65
Merged
Conversation
kumavis
approved these changes
Apr 20, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After upgrading this repo to version 4.1.0 I installed this package in eth-hd-keyring and tried to run tests and it failed because the version of node I use (14) is incompatible with scrypt which is a dependency of older versions of ethereumjs-wallet. I am upgrading this but didn't make any other changes related to specifying node version. This will enable a pr in eth-hd-keyring to do the same.