deps: replace tweetnacl-util with @scure/base#358
Merged
legobeat merged 1 commit intoMetaMask:mainfrom May 1, 2024
Merged
Conversation
fb8fce3 to
1b64baf
Compare
1b64baf to
8daca4d
Compare
- `tweetnacl-util` is no longer actively maintained - `@scure/base` is already pulled in transitively through `ethereum-cryptography` - Remove redundant base64 encode/decode step when decoding hex input
8daca4d to
c34eb6c
Compare
Mrtenz
reviewed
May 1, 2024
| case 'x25519-xsalsa20-poly1305': { | ||
| // string to buffer to UInt8Array | ||
| const receiverPrivateKeyUint8Array = naclDecodeHex(privateKey); | ||
| const receiverPrivateKeyUint8Array = Buffer.from(privateKey, 'hex'); |
Member
There was a problem hiding this comment.
Can we use @metamask/utils instead of Node.js globals?
Contributor
Author
There was a problem hiding this comment.
Can we address that in a separate PR? The native Buffer.from is already used by this function (from here), so we're not introducing it in this PR.
Mrtenz
approved these changes
May 1, 2024
This was referenced May 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tweetnacl-utilis no longer actively maintained@scure/baseis already pulled in transitively throughethereum-cryptographyRelated