Skip to content

fix: remove unused private props eth and provider#60

Merged
legobeat merged 1 commit intoMetaMask:mainfrom
legobeat:remove-unused-private-prop
Feb 6, 2024
Merged

fix: remove unused private props eth and provider#60
legobeat merged 1 commit intoMetaMask:mainfrom
legobeat:remove-unused-private-prop

Conversation

@legobeat
Copy link
Copy Markdown
Contributor

@legobeat legobeat commented Feb 2, 2024

The passed provider and its Eth instance are only used inside the constructor. This removes the corresponding unused private properties.

@legobeat legobeat changed the title remove unused private props eth and provider fix: remove unused private props eth and provider Feb 2, 2024
@legobeat legobeat marked this pull request as ready for review February 2, 2024 20:07
@legobeat legobeat requested a review from a team as a code owner February 2, 2024 20:07
Copy link
Copy Markdown
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, makes sense.

@legobeat legobeat merged commit afffdf9 into MetaMask:main Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants