Conversation
Merged
Member
Author
|
Notice how tests are failing for #26 at the moment. |
Gudahtt
reviewed
Jan 13, 2021
Member
Gudahtt
left a comment
There was a problem hiding this comment.
This is better than failing tests, but it's still not great to be hitting Infura in unit tests 😬. What would it take to replace this with ganache instead? We'd probably need to deploy this method registry contract I'm guessing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unit tests make requests to Infura. This package was using the deprecated (removed?) Infura v1 API. This PR adds the
rcdependency such that developers can add their Infura API keys for tests. It also adds the creation of anrcfile for CI.