Merged
Conversation
The provider is now a required option. This seemed preferable to embedding another default provider that might also become obsolete. It's commonplace for eth-related libraries to require a provider to be passed in.
whymarrh
approved these changes
Mar 17, 2020
Contributor
whymarrh
left a comment
There was a problem hiding this comment.
This is a good (albeit, breaking) change
Member
Author
|
This won't actually break anything, since this default provider is already broken. But sure, it makes sense to consider this a breaking change. |
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The provider is now a required option. This seemed preferable to embedding another default provider that might also become obsolete. It's commonplace for eth-related libraries to require a provider to be passed in.