Skip to content
This repository was archived by the owner on Nov 9, 2023. It is now read-only.

Switch license to MIT and apply package.json constraints ahead of migration to core monorepo#30

Closed
MajorLift wants to merge 3 commits intomainfrom
230928-switch-license-to-mit-apply-packagejson-constraints
Closed

Switch license to MIT and apply package.json constraints ahead of migration to core monorepo#30
MajorLift wants to merge 3 commits intomainfrom
230928-switch-license-to-mit-apply-packagejson-constraints

Conversation

@MajorLift
Copy link
Copy Markdown
Contributor

@MajorLift MajorLift commented Sep 28, 2023

Description

  • Switches license to MIT.
  • Applies core monorepo constraints for package.json.

References

@MajorLift MajorLift requested a review from a team as a code owner September 28, 2023 22:34
@MajorLift MajorLift mentioned this pull request Sep 28, 2023
1 task
@MajorLift MajorLift force-pushed the 230928-switch-license-to-mit-apply-packagejson-constraints branch from 4325fc8 to d38f8fa Compare September 28, 2023 22:37
@legobeat
Copy link
Copy Markdown
Contributor

The MIT license change would require sign-offs from past contributors (stretching past the git history of this repository). See #13

@MajorLift
Copy link
Copy Markdown
Contributor Author

MajorLift commented Sep 29, 2023

Would it be acceptable to keep the license as ISC in the last release here (probably 2.2.0), and switch to MIT in core once the package has been migrated? It feels like that would be sidestepping the sign-off requirements, and I'm not sure if there are issues that could be caused by taking that route.

@MajorLift
Copy link
Copy Markdown
Contributor Author

Closing and keeping license as ISC.

@MajorLift MajorLift closed this Sep 29, 2023
@legobeat legobeat deleted the 230928-switch-license-to-mit-apply-packagejson-constraints branch September 30, 2023 01:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants