Skip to content
This repository was archived by the owner on Oct 16, 2025. It is now read-only.

refactor!: Remove ethersProviderAsMiddleware#415

Merged
rekmarks merged 3 commits intomainfrom
rekm/remove-ethersproviderasmiddleware
Oct 7, 2025
Merged

refactor!: Remove ethersProviderAsMiddleware#415
rekmarks merged 3 commits intomainfrom
rekm/remove-ethersproviderasmiddleware

Conversation

@rekmarks
Copy link
Copy Markdown
Member

@rekmarks rekmarks commented Oct 7, 2025

We do not use ethersProviderAsMiddleware internally, which additionally relies on a method of our internal, non-standard provider type that we are trying to get rid of. In consequence of this, this PR removes this function.


Note

Removes ethersProviderAsMiddleware and documents it as a breaking change in the changelog.

  • Source (src/providerAsMiddleware.ts):
    • Remove ethersProviderAsMiddleware and related PendingJsonRpcResponse import.
  • Docs (CHANGELOG.md):
    • Add Unreleased note under Removed: BREAKING removal of ethersProviderAsMiddleware.

Written by Cursor Bugbot for commit 5448925. This will update automatically on new commits. Configure here.

@rekmarks rekmarks requested a review from a team as a code owner October 7, 2025 20:40
Copy link
Copy Markdown
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! I did a quick search and didn't find anywhere we are using this.

@rekmarks rekmarks merged commit df9dc39 into main Oct 7, 2025
20 checks passed
@rekmarks rekmarks deleted the rekm/remove-ethersproviderasmiddleware branch October 7, 2025 21:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants