This repository was archived by the owner on Oct 16, 2025. It is now read-only.
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
The only change that affects this package is in 11.3.0, where some types were changed so that if they take a type parameter that `extends Json`, they default to `Json` itself. Because of our lint rules that forced some changes in this PR itself. There should be no backward-incompatible changes, however. `object` is deprecated, so we do need to adapt to that at some point, but we can address that in a future PR.
Mrtenz
previously approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for upgrading the copy of
AbstractRpcServicein this repo to match the newest version of@metamask/network-controller.The only version of
@metamask/utilsthat could affect this package is in 11.3.0, where some types were changed so that if they take a type parameter thatextends Json, they default toJsonitself. Because of our lint rules, that forced some changes in this PR itself. Regardless, these changes should be backwards-compatible.Additionally, we are using
objectfrom@metamask/utilsand that is now deprecated, so we do need to adapt to that at some point. But we can address that in a future PR.