This repository was archived by the owner on Oct 16, 2025. It is now read-only.
Remove legacy signature/code for createFetchMiddleware#402
Merged
Conversation
Now that `createFetchMiddleware` takes an `RpcService`, there is no need for it to take its old signature (`fetch`, `btoa`, `rpcUrl`, and `originHttpHeaderKey`), and there is no need for the old logic (as that has been integrated into `RpcService`).
Mrtenz
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that
createFetchMiddlewaretakes anRpcService, there is no need for it to take its old signature (fetch,btoa,rpcUrl, andoriginHttpHeaderKey), and there is no need for the old logic (as that has been integrated intoRpcService).