This repository was archived by the owner on Oct 16, 2025. It is now read-only.
refactor: fully extract middleware into EIP-5792 Middleware (monorepo) package#401
Merged
ffmcgee725 merged 2 commits intomainfrom Sep 10, 2025
Merged
refactor: fully extract middleware into EIP-5792 Middleware (monorepo) package#401ffmcgee725 merged 2 commits intomainfrom
ffmcgee725 merged 2 commits intomainfrom
Conversation
jiexi
approved these changes
Sep 8, 2025
jiexi
reviewed
Sep 8, 2025
Member
jiexi
left a comment
There was a problem hiding this comment.
Unsure what the convention is for this repo (or if it's the same for all repos), but maybe add a CHANGELOG entry?
Member
Author
|
@jiexi digging into other PRs, it seems the pattern in this repo is to update |
mcmire
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The newly created EIP-5792 Middleware package (PR #6422) currently contains only the hooks required for the existing wallet middleware. To align with the intended abstraction and reduce the monolithic nature of wallet-middleware, we should fully extract the relevant middleware logic from eth-json-rpc-middleware (GitHub - MetaMask/eth-json-rpc-middleware: Ethereum middleware for composing an Ethereum provider using json-rpc-engine. Intended to replace provider-engine) into this new package.
This PR removes the identified middleware into @metamask/eip-5792-middleware.
PR #6477 from https://github.com/MetaMask/core moves this middleware to the specified package.