This repository was archived by the owner on Oct 16, 2025. It is now read-only.
Merged
Conversation
Validate using superstruct.
Add unit tests.
jiexi
reviewed
Feb 11, 2025
jiexi
reviewed
Feb 11, 2025
jiexi
reviewed
Feb 11, 2025
jiexi
reviewed
Feb 11, 2025
jiexi
reviewed
Feb 11, 2025
jiexi
reviewed
Feb 11, 2025
jiexi
reviewed
Feb 11, 2025
jiexi
reviewed
Feb 11, 2025
jiexi
reviewed
Feb 11, 2025
jiexi
reviewed
Feb 11, 2025
jiexi
reviewed
Feb 11, 2025
jiexi
reviewed
Feb 11, 2025
jiexi
reviewed
Feb 11, 2025
jiexi
reviewed
Feb 11, 2025
jiexi
reviewed
Feb 11, 2025
Add unit test. Update types.
OGPoyraz
approved these changes
Feb 12, 2025
jiexi
approved these changes
Feb 12, 2025
cryptodev-2s
approved these changes
Feb 14, 2025
Contributor
cryptodev-2s
left a comment
There was a problem hiding this comment.
LGTM, I left a tiny typo fix comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support the EIP-5792 methods:
wallet_sendCallswallet_getCallsStatuswallet_getCapabilitiesSpecifically:
src/methods.src/wallet.ts.@metamask/superstructto easily validate request parameters against a schema / struct.src/validation.ts.*for easier API diffs.An additional benefit of using
@metamask/superstructis including multiple validation errors within a single RPC error: