Skip to content

Fix Node.js v18+ compatibility#94

Closed
legobeat wants to merge 0 commit intoMetaMask:mainfrom
legobeat:fix-nodejs-18-compat
Closed

Fix Node.js v18+ compatibility#94
legobeat wants to merge 0 commit intoMetaMask:mainfrom
legobeat:fix-nodejs-18-compat

Conversation

@legobeat
Copy link
Copy Markdown
Contributor

@legobeat legobeat commented Sep 1, 2023 •
edited
Loading

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Sep 1, 2023 •
edited
Loading

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
eslint-plugin-promise 6.1.1 None +5 2.78 MB eslint-community-bot
eslint-plugin-n 15.7.0 filesystem +9 3.39 MB weiran.zsd
@metamask/eslint-config-jest 9.0.0...12.1.0 None +70/-86 95.7 MB metamaskbot
@metamask/eslint-config-typescript 9.0.1...12.1.0 None +69/-85 95.3 MB metamaskbot
typescript 4.4.4...4.8.4 None +0/-0 68.8 MB typescript-bot
@metamask/eslint-config-nodejs 9.0.0...12.1.0 None +61/-78 22.7 MB metamaskbot
@metamask/eslint-config 9.0.0...12.1.0 None +57/-75 22.1 MB metamaskbot
@typescript-eslint/eslint-plugin 4.33.0...5.62.0 None +15/-50 75.9 MB jameshenry
@typescript-eslint/parser 4.33.0...5.62.0 None +10/-47 72.9 MB jameshenry
eslint-plugin-prettier 3.4.1...4.2.1 None +6/-43 14 MB jounqin
eslint-plugin-jsdoc 36.1.1...43.0.7 None +9/-47 5.17 MB gajus
prettier 2.6.1...2.8.8 environment +0/-0 11.2 MB prettier-bot
eslint-plugin-import 2.25.4...2.28.1 None +48/-66 8.22 MB ljharb
eslint-plugin-jest 24.7.0...27.2.3 None +17/-51 76.3 MB simenb

🚮 Removed packages: eslint@7.32.0, eslint-plugin-node@11.1.0

@legobeat legobeat force-pushed the fix-nodejs-18-compat branch from 75878b0 to 020e4aa Compare September 1, 2023 05:45
@legobeat legobeat mentioned this pull request Sep 1, 2023
Merged
4 tasks
@socket-security
Copy link
Copy Markdown

socket-security Bot commented Sep 1, 2023 •
edited
Loading

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Obfuscated require eslint-plugin-es 4.1.0
Obfuscated require resolve 1.22.4

Ignoring: for-each@0.3.3, functions-have-names@1.2.3, globalthis@1.0.3, available-typed-arrays@1.0.5, builtins@5.0.1, typed-array-length@1.0.4, es-shim-unscopables@1.0.0, natural-compare-lite@1.4.0, has-property-descriptors@1.0.0

Next steps

What is obfuscated require?

Package accesses dynamic properties of require and may be obfuscating code execution.

The package should not access dynamic properties of module. Instead use import or require directly.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore eslint-plugin-es@4.1.0
  • @SocketSecurity ignore resolve@1.22.4

@legobeat
Copy link
Copy Markdown
Contributor Author

legobeat commented Sep 1, 2023 

@SocketSecurity ignore for-each@0.3.3
@SocketSecurity ignore functions-have-names@1.2.3
@SocketSecurity ignore globalthis@1.0.3
@SocketSecurity ignore available-typed-arrays@1.0.5
@SocketSecurity ignore builtins@5.0.1
@SocketSecurity ignore typed-array-length@1.0.4
@SocketSecurity ignore es-shim-unscopables@1.0.0
@SocketSecurity ignore natural-compare-lite@1.4.0
@SocketSecurity ignore has-property-descriptors@1.0.0
@SocketSecurity ignore eslint-plugin-n@15.7.0

This was referenced Sep 1, 2023
Merged
Merged
Merged
@legobeat legobeat mentioned this pull request Sep 10, 2023
Merged
14 tasks
@legobeat legobeat force-pushed the fix-nodejs-18-compat branch from 020e4aa to 83a959b Compare September 11, 2023 13:15
@legobeat legobeat mentioned this pull request Sep 13, 2023
Closed
34 tasks
@legobeat legobeat closed this Sep 20, 2023
@legobeat legobeat force-pushed the fix-nodejs-18-compat branch from 83a959b to c45826e Compare September 20, 2023 02:43
@legobeat
Copy link
Copy Markdown
Contributor Author

legobeat commented Sep 20, 2023

This is resolved as of #90

@legobeat legobeat deleted the fix-nodejs-18-compat branch September 20, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@legobeat