Skip to content

Replace await-semaphore with async-mutex.#33

Merged
Gudahtt merged 1 commit intomainfrom
replace-await-semaphore
Feb 3, 2021
Merged

Replace await-semaphore with async-mutex.#33
Gudahtt merged 1 commit intomainfrom
replace-await-semaphore

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Feb 2, 2021

We've had issues with await-semaphore causing TypeScript errors due to mistakes in how it is packaged. It generally seems to be abandoned.

async-mutex is more actively maintained, has better documentation and test coverage, and is API-compatible for our usage.

We've had issues with await-semaphore causing TypeScript errors due to
mistakes in how it is packaged. It generally seems to be abandoned.

async-mutex is more actively maintained, has better documentation and
test coverage, and is API-compatible for our usage.
Copy link
Copy Markdown
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 720bae6 into main Feb 3, 2021
@Gudahtt Gudahtt deleted the replace-await-semaphore branch February 3, 2021 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants