This repository was archived by the owner on Oct 7, 2024. It is now read-only.
Revert Typescript migration (#90)#101
Merged
legobeat merged 1 commit intoMetaMask:mainfrom Sep 26, 2023
Merged
Conversation
This reverts commit f2a6d07
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: @metamask/eslint-config-typescript@11.1.0, @types/node@18.18.0, @typescript-eslint/eslint-plugin@6.7.3, @typescript-eslint/parser@5.62.0, eslint-plugin-jsdoc@46.8.2, ts-jest@29.1.1, ts-node@10.9.1, typedoc@0.23.28, typescript@4.9.5 |
This was referenced Sep 25, 2023
Gudahtt
approved these changes
Sep 26, 2023
Member
Gudahtt
left a comment
There was a problem hiding this comment.
LGTM! I compared this branch to v6.0.0 and it looks like the only changes are to the minimum supported Node.js version and the dependency bumps (and one minor code refactor related to one of these bumps)
Contributor
Author
|
Backported to v6 in #102 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes:
jest,@types/jestindex.js)