This repository was archived by the owner on Oct 16, 2025. It is now read-only.
fix: PollingBlockTracker.getLatestBlock to handle network failures#313
Merged
cryptodev-2s merged 4 commits intomainfrom May 2, 2025
Merged
Conversation
bca3298 to
a03f89d
Compare
a03f89d to
a47ec4c
Compare
Contributor
|
This looks pretty good so far! There are some duplicate tests now but I think we can clean that up later. Perhaps to fix the failing tests you could call |
Contributor
Author
That's exactly what I am doing |
90b37df to
6972ebb
Compare
…-tracker-get-latest-block-timeout
mcmire
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Block Tracker's getLatestBlock Method to Handle Network Failures
Fixes: #311