Merged
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
I propose that we remove this rule. I would argue that adding logic to tests is not as harmful as the docs for this rule would indicate and in fact can be quite useful. - When mocking functions with overloads, it is necessary to add logic inside of the mock implementation to handle different arguments. - When testing a function that can be called multiple ways where the behavior is mostly the same between inputs aside from a few edge cases, using an `if` statement to highlight the difference can be useful.
79d3242 to
cdbb0d7
Compare
Mrtenz
approved these changes
Feb 19, 2025
Member
Mrtenz
left a comment
There was a problem hiding this comment.
I agree. This rule seems to be too strict in Snaps as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose that we remove this rule. I would argue that adding logic to tests is not as harmful as the docs for this rule would indicate and in fact can be quite useful.
ifstatement to highlight the difference can be useful.