Merged
Conversation
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
rekmarks
reviewed
Sep 24, 2024
bfe8980 to
72d11d8
Compare
mikesposito
approved these changes
Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new package,
@metamask/eslint-config-vitest, which configures rules for Vitest tests. Vitest has a plugin with almost identical rules as the Jest plugin, so the rules are essentially the recommended Vitest rules, and whatever rules we had enabled for Jest. The rule snapshots for Jest and Vitest are nearly identical.