Add eslint-plugin-promise and enable no-multiple-resolved#287
Merged
Conversation
The plugin is added to the eslint configuration, with the no-multiple-resolved rule enabled. This avoids situations where both `resolve()` and `reject()` can be called, due to a missing `return` statement.
|
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
|
pedronfigueiredo
approved these changes
May 4, 2023
bergarces
approved these changes
May 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds the
eslint-plugin-promisepackage as a dependency to our project and adds theno-multiple-resolvedrule to ESLint configuration with this plugin enabled. This avoids the error-prone situation where bothresolve()andreject()can be called.Changes
eslint-plugin-promiseto the base package dependencies.no-multiple-resolvedrule to the ESLint configuration.rules-snapshot.jsonto include the new rule.