Skip to content

Exclude test files from package#266

Merged
Gudahtt merged 1 commit intomainfrom
exclude-test-files-from-package
Dec 13, 2022
Merged

Exclude test files from package#266
Gudahtt merged 1 commit intomainfrom
exclude-test-files-from-package

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Dec 13, 2022

Test files are now excluded from each package. They have been included in recent releases.

Test files are now excluded from each package. They have been included
in recent releases.
@Gudahtt Gudahtt requested a review from a team as a code owner December 13, 2022 00:27
Copy link
Copy Markdown
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Maybe we want to do this in our other repos. Good catch though.

@Gudahtt
Copy link
Copy Markdown
Member Author

Gudahtt commented Dec 13, 2022

I remember catching this on one of our other JavaScript repos. There might be some with the same problem though. It's not an issue with TypeScript libraries because no tests end up in dist/.

@Gudahtt Gudahtt merged commit 4ff88e8 into main Dec 13, 2022
@Gudahtt Gudahtt deleted the exclude-test-files-from-package branch December 13, 2022 05:19
@mcmire
Copy link
Copy Markdown
Contributor

mcmire commented Dec 13, 2022

Ah! Good point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants