Skip to content

Disable import/no-nodejs-modules in Node.js config#257

Merged
Mrtenz merged 1 commit intomainfrom
mrtenz/disable-no-nodejs-modules
Nov 17, 2022
Merged

Disable import/no-nodejs-modules in Node.js config#257
Mrtenz merged 1 commit intomainfrom
mrtenz/disable-no-nodejs-modules

Conversation

@Mrtenz
Copy link
Copy Markdown
Member

@Mrtenz Mrtenz commented Nov 17, 2022

import/no-nodejs-modules was enabled in the base config in #242, but incorrectly not disabled in the Node.js config. I've fixed that here.

@Mrtenz Mrtenz requested a review from a team as a code owner November 17, 2022 12:38
@Mrtenz Mrtenz force-pushed the mrtenz/disable-no-nodejs-modules branch from 1bec3fa to 16df457 Compare November 17, 2022 12:38
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mrtenz Mrtenz merged commit ade6955 into main Nov 17, 2022
@Mrtenz Mrtenz deleted the mrtenz/disable-no-nodejs-modules branch November 17, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants