This repository was archived by the owner on Nov 26, 2024. It is now read-only.
Fix Broken CSS Export in Design Tokens Package#609
Merged
georgewrmarshall merged 1 commit intomainfrom Feb 2, 2024
Merged
Conversation
georgewrmarshall
commented
Feb 2, 2024
| % during the build step. | ||
| gen_enforced_field(WorkspaceCwd, 'files', ['dist']). | ||
| gen_enforced_field(WorkspaceCwd, 'files', ['dist', 'src/css/']). | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
This lints the package.json folder when running yarn lint
garrettbear
approved these changes
Feb 2, 2024
georgewrmarshall
commented
Feb 2, 2024
| "files": [ | ||
| "dist" | ||
| "dist", | ||
| "src/css/" |
Collaborator
Author
There was a problem hiding this comment.
Originally how we had it before v2 update https://github.com/MetaMask/design-tokens/pull/601/files#r1476736756
This was referenced Feb 6, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue of the broken CSS export in the design tokens package that occurred after the v2 release. The fix ensures that the CSS export functions correctly and can be used without issues in projects that depend on it.
Related issues
Fixes: #608
Manual testing steps
npm packthis creates a tarball of the same format that would be sent to the registryScreenshots/Recordings
Before
Running
npm packbefore updatebefore.mov
After
Running
npm packafter update and inspecting folderafter.mov
Pre-merge author checklist
Pre-merge reviewer checklist