Skip to content

fix: replace null with intentionally-skip in release-spec template comment#99

Merged
legobeat merged 1 commit intoMetaMask:mainfrom
legobeat:fix-intentionally-skip-in-spec-template
Sep 13, 2023
Merged

fix: replace null with intentionally-skip in release-spec template comment#99
legobeat merged 1 commit intoMetaMask:mainfrom
legobeat:fix-intentionally-skip-in-spec-template

Conversation

@legobeat
Copy link
Copy Markdown
Contributor

Alternative to #92 to make the current behavior more immediately obvious and the comment more helpful.

@legobeat legobeat requested a review from a team as a code owner September 13, 2023 00:42
@legobeat legobeat force-pushed the fix-intentionally-skip-in-spec-template branch from d160d2e to 4aeb19a Compare September 13, 2023 00:44
@legobeat legobeat force-pushed the fix-intentionally-skip-in-spec-template branch from 4aeb19a to cf98489 Compare September 13, 2023 01:21
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat merged commit 73f60d0 into MetaMask:main Sep 13, 2023
@legobeat legobeat deleted the fix-intentionally-skip-in-spec-template branch September 13, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants