fix: gracefully handle browser open failures#178
Merged
cryptodev-2s merged 2 commits intomainfrom Apr 17, 2025
Merged
Conversation
502ba02 to
0f2b9b2
Compare
0f2b9b2 to
3ae4579
Compare
4 tasks
cryptodev-2s
commented
Apr 17, 2025
| ); | ||
|
|
||
| if (interactive) { | ||
| stdout.write(`Starting UI on port ${port}...\n`); |
Contributor
Author
There was a problem hiding this comment.
Removed as redundant
mcmire
approved these changes
Apr 17, 2025
Contributor
mcmire
left a comment
There was a problem hiding this comment.
Superb manual testing steps. I tried all of them and they worked. Nice job!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the error handling when automatically opening the browser fails. Several users have reported issues with the
create-release-branchtool failing when their terminal application lacks sufficient privileges for System Events or when using non-standard browsers like Brave.Instead of failing with an unclear osascript error, the tool now:
Testing Instructions
Prerequisites
Test Case 1: System Events Permission Disabled
First, test current behavior on main:
git checkout main yarn build // use package locally (eg: from Core repo) yarn && yarn create-release-branch -iDisable System Events permission:
Test the fix:
git checkout fix/handle-macos-browser-open-permissions yarn build // use package locally (eg: from Core repo) yarn && yarn create-release-branch -iTest Case 2: Non-standard Browser (Brave)
Set Brave as your default browser
Test current behavior on main:
git checkout main yarn build // use package locally (eg: from Core repo) yarn && yarn create-release-branch -iTest the fix:
git checkout fix/handle-macos-browser-open-permissions yarn build // use package locally (eg: from Core repo) yarn && yarn create-release-branch -ia) Browser opens successfully in Brave, or
b) Clear instructions to open the URL manually