fix: limit breaking change dependent detection to peer dependencies#170
Merged
cryptodev-2s merged 1 commit intomainfrom Mar 4, 2025
Merged
Conversation
mcmire
approved these changes
Mar 4, 2025
Contributor
mcmire
left a comment
There was a problem hiding this comment.
Thanks for making this change so quickly!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refines our breaking change dependent detection logic to only consider peer dependencies. This change supports our policy of requiring packages with breaking changes to be released alongside their dependents.
Changes
validateReleaseSpecificationto check onlypeerDependencieswhen determining dependent packages that must be released together with packages containing breaking changesWhen a package introduces breaking changes, we need to ensure that packages directly affected by those changes are released simultaneously. Peer dependencies represent a more critical relationship where breaking changes have a direct impact, while regular dependencies can often adapt to breaking changes through internal implementation details.