feat: release UI beta by cryptodev-2s · Pull Request #166 · MetaMask/create-release-branch

cryptodev-2s · 2025-02-20T15:37:09Z

The Release UI Beta

You can test the new feature in create-release-branch locally with Core by following these steps:

1️⃣ Checkout the Feature Branch

git checkout cryptodev2s/release-ui-beta

3️⃣ Run the Command in create-release-branch

yarn && yarn build

4️⃣ Update Core’s package.json

Modify package.json in Core to point create-release-branch to the local build.

4️⃣ Run the Command in Core

yarn && yarn create-release-branch -i

Fixes: #163

socket-security · 2025-02-20T15:37:37Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/iconv-lite@0.4.24, npm/extend@3.0.2, npm/mime-types@2.1.35, npm/mime-db@1.52.0, npm/content-disposition@0.5.4, npm/ms@2.1.3, npm/on-finished@2.4.1, npm/ee-first@1.1.1, npm/detect-libc@1.0.3, npm/methods@1.1.2, npm/type-is@1.6.18, npm/media-typer@0.3.0, npm/tapable@2.2.1, npm/accepts@1.3.8, npm/array-flatten@1.1.1, npm/bail@2.0.2, npm/bytes@3.1.2, npm/ccount@2.0.1, npm/character-entities@2.0.2, npm/content-type@1.0.5, npm/cookie-signature@1.0.6, npm/decode-named-character-reference@1.0.2, npm/depd@2.0.0, npm/dequal@2.0.3, npm/destroy@1.2.0, npm/encodeurl@1.0.2, npm/escape-html@1.0.3, npm/etag@1.8.1, npm/forwarded@0.2.0, npm/fresh@0.5.2, npm/http-errors@2.0.0, npm/ipaddr.js@1.9.1, npm/longest-streak@3.1.0, npm/mime@1.6.0, npm/parseurl@1.3.3, npm/proxy-addr@2.0.7, npm/range-parser@1.2.1, npm/setprototypeof@1.2.0, npm/statuses@2.0.1, npm/toidentifier@1.0.1, npm/unpipe@1.0.0, npm/utils-merge@1.0.1, npm/vary@1.1.2, npm/zwitch@2.0.4, npm/define-lazy-prop@3.0.0, npm/is-inside-container@1.0.0, npm/is-docker@3.0.0, npm/comma-separated-tokens@2.0.3, npm/space-separated-tokens@2.0.2, npm/trim-lines@3.0.1, npm/character-entities-html4@2.1.0, npm/character-entities-legacy@3.0.0, npm/raw-body@2.5.2, npm/character-reference-invalid@2.0.1, npm/devlop@1.1.0, npm/hast-util-whitespace@3.0.0, npm/is-alphabetical@2.0.1, npm/is-alphanumerical@2.0.1, npm/is-decimal@2.0.1, npm/is-hexadecimal@2.0.1, npm/mdast-util-to-string@4.0.0, npm/remark-parse@11.0.0, npm/unist-util-is@6.0.0, npm/unist-util-position@5.0.0, npm/unist-util-stringify-position@4.0.0, npm/unist-util-visit-parents@6.0.1, npm/unist-util-visit@5.0.0, npm/vfile-message@4.0.2, npm/is-wsl@3.1.0, npm/estree-util-is-identifier-name@3.0.0, npm/mdast-util-mdxjs-esm@2.0.1, npm/@types/body-parser@1.19.5, npm/@types/connect@3.4.38, npm/@types/http-errors@2.0.4, npm/@types/range-parser@1.2.7, npm/@types/send@0.17.4, npm/@types/mime@1.3.5, npm/merge-descriptors@1.0.3, npm/csstype@3.1.3, npm/default-browser-id@5.0.0, npm/run-applescript@7.0.0, npm/bundle-name@4.1.0, npm/default-browser@5.2.1, npm/@types/hast@3.0.4, npm/mdast-util-phrasing@4.1.0, npm/es-errors@1.3.0, npm/trough@2.2.0, npm/@types/estree-jsx@1.0.5, npm/@jridgewell/set-array@1.2.1, npm/@jridgewell/trace-mapping@0.3.25, npm/open@10.1.0, npm/encodeurl@2.0.0, npm/@types/serve-static@1.15.7, npm/property-information@6.5.0, npm/stringify-entities@4.0.4, npm/react-refresh@0.14.2, npm/@types/mdast@4.0.4, npm/react@19.0.0, npm/react-dom@19.0.0, npm/mdast-util-to-hast@13.2.0, npm/unified@11.0.5, npm/qs@6.13.0, npm/@types/unist@3.0.3, npm/@types/unist@2.0.11, npm/vfile@6.0.3, npm/inline-style-parser@0.2.4, npm/escalade@3.2.0, npm/source-map-js@1.2.1, npm/body-parser@1.20.3, npm/send@0.19.0, npm/serve-static@1.16.2, npm/style-to-object@1.0.8, npm/finalhandler@1.3.1, npm/mdast-util-mdx-expression@2.0.1, npm/@types/estree@1.0.6, npm/remark-rehype@11.1.1, npm/@types/express@5.0.0, npm/html-url-attributes@3.0.1, npm/cookie@0.7.1, npm/hast-util-to-jsx-runtime@2.3.2, npm/picocolors@1.1.1, npm/@babel/helper-validator-identifier@7.25.9, npm/@babel/helper-validator-option@7.25.9, npm/@babel/helper-module-imports@7.25.9, npm/@babel/helper-string-parser@7.25.9, npm/@babel/plugin-transform-react-jsx-self@7.25.9, npm/@babel/plugin-transform-react-jsx-source@7.25.9, npm/@babel/helper-module-transforms@7.26.0, npm/mdast-util-from-markdown@2.0.2, npm/@babel/code-frame@7.26.2, npm/mdast-util-to-markdown@2.1.2, npm/micromark-util-normalize-identifier@2.0.1, npm/micromark-util-html-tag-name@2.0.1, npm/micromark-util-encode@2.0.1, npm/micromark-util-decode-numeric-character-reference@2.0.2, npm/micromark-util-decode-string@2.0.1, npm/micromark-util-combine-extensions@2.0.1, npm/micromark-util-classify-character@2.0.1, npm/micromark-factory-whitespace@2.0.1, npm/micromark-util-chunked@2.0.1, npm/micromark-factory-space@2.0.1, npm/micromark-util-sanitize-uri@2.0.1, npm/micromark@4.0.1, npm/micromark-core-commonmark@2.0.2, npm/micromark-factory-destination@2.0.1, npm/micromark-factory-label@2.0.1, npm/micromark-factory-title@2.0.1, npm/micromark-util-character@2.1.1, npm/micromark-util-resolve-all@2.0.1, npm/micromark-util-symbol@2.0.1, npm/micromark-util-types@2.0.1, npm/@vitejs/plugin-react@4.3.4, npm/nanoid@3.3.8, npm/gopd@1.2.0, npm/scheduler@0.25.0, npm/path-to-regexp@0.1.12, npm/express@4.21.2, npm/es-define-property@1.0.1, npm/node-releases@2.0.19, npm/side-channel-map@1.0.1, npm/side-channel-list@1.0.0, npm/side-channel-weakmap@1.0.2, npm/jsesc@3.1.0, npm/@jridgewell/gen-mapping@0.3.8, npm/parse-entities@4.0.2, npm/call-bound@1.0.3, npm/dunder-proto@1.0.1, npm/jiti@2.4.2, npm/math-intrinsics@1.1.0, npm/get-proto@1.0.1, npm/react-markdown@9.0.3, npm/update-browserslist-db@1.1.2, npm/browserslist@4.24.4, npm/lightningcss-darwin-arm64@1.29.1, npm/lightningcss-darwin-x64@1.29.1, npm/lightningcss-freebsd-x64@1.29.1, npm/lightningcss-linux-arm-gnueabihf@1.29.1, npm/lightningcss-linux-arm64-gnu@1.29.1, npm/lightningcss-linux-arm64-musl@1.29.1, npm/lightningcss-linux-x64-gnu@1.29.1, npm/lightningcss-linux-x64-musl@1.29.1, npm/lightningcss-win32-arm64-msvc@1.29.1, npm/lightningcss-win32-x64-msvc@1.29.1, npm/lightningcss@1.29.1, npm/@babel/helper-compilation-targets@7.26.5, npm/@babel/helper-plugin-utils@7.26.5, npm/@types/react-dom@19.0.3, npm/mdast-util-mdx-jsx@3.2.0, npm/@types/qs@6.9.18, npm/es-object-atoms@1.1.1, npm/micromark-util-subtokenize@2.0.4, npm/@types/react@19.0.8, npm/@ungap/structured-clone@1.3.0, npm/@types/express-serve-static-core@5.0.6, npm/enhanced-resolve@5.18.1, npm/@esbuild/aix-ppc64@0.25.0, npm/@esbuild/android-arm64@0.25.0, npm/@esbuild/android-arm@0.25.0, npm/@esbuild/android-x64@0.25.0, npm/@esbuild/darwin-arm64@0.25.0, npm/@esbuild/darwin-x64@0.25.0, npm/@esbuild/freebsd-arm64@0.25.0, npm/@esbuild/freebsd-x64@0.25.0, npm/@esbuild/linux-arm64@0.25.0, npm/@esbuild/linux-arm@0.25.0, npm/@esbuild/linux-ia32@0.25.0, npm/@esbuild/linux-loong64@0.25.0, npm/@esbuild/linux-mips64el@0.25.0, npm/@esbuild/linux-ppc64@0.25.0, npm/@esbuild/linux-riscv64@0.25.0, npm/@esbuild/linux-s390x@0.25.0, npm/@esbuild/linux-x64@0.25.0, npm/@esbuild/netbsd-arm64@0.25.0, npm/@esbuild/netbsd-x64@0.25.0, npm/@esbuild/openbsd-arm64@0.25.0, npm/@esbuild/openbsd-x64@0.25.0, npm/@esbuild/sunos-x64@0.25.0, npm/@esbuild/win32-arm64@0.25.0, npm/@esbuild/win32-ia32@0.25.0, npm/@esbuild/win32-x64@0.25.0, npm/esbuild@0.25.0, npm/@babel/compat-data@7.26.8, npm/call-bind-apply-helpers@1.0.2, npm/@babel/parser@7.26.9, npm/@babel/types@7.26.9, npm/@babel/core@7.26.9, npm/@babel/generator@7.26.9, npm/@babel/helpers@7.26.9, npm/@babel/template@7.26.9, npm/@babel/traverse@7.26.9, npm/caniuse-lite@1.0.30001700, npm/rollup@4.34.8, npm/@rollup/rollup-darwin-arm64@4.34.8, npm/@rollup/rollup-android-arm64@4.34.8, npm/@rollup/rollup-win32-arm64-msvc@4.34.8, npm/@rollup/rollup-freebsd-arm64@4.34.8, npm/@rollup/rollup-linux-arm64-gnu@4.34.8, npm/@rollup/rollup-linux-arm64-musl@4.34.8, npm/@rollup/rollup-android-arm-eabi@4.34.8, npm/@rollup/rollup-linux-arm-gnueabihf@4.34.8, npm/@rollup/rollup-linux-arm-musleabihf@4.34.8, npm/@rollup/rollup-win32-ia32-msvc@4.34.8, npm/@rollup/rollup-linux-loongarch64-gnu@4.34.8, npm/@rollup/rollup-linux-riscv64-gnu@4.34.8, npm/@rollup/rollup-linux-powerpc64le-gnu@4.34.8, npm/@rollup/rollup-linux-s390x-gnu@4.34.8, npm/@rollup/rollup-darwin-x64@4.34.8, npm/@rollup/rollup-win32-x64-msvc@4.34.8, npm/@rollup/rollup-freebsd-x64@4.34.8, npm/@rollup/rollup-linux-x64-gnu@4.34.8, npm/@rollup/rollup-linux-x64-musl@4.34.8, npm/postcss@8.5.3, npm/electron-to-chromium@1.5.104, npm/vite@6.2.0, npm/tailwindcss@4.0.9, npm/@tailwindcss/node@4.0.9, npm/@tailwindcss/oxide@4.0.9, npm/@tailwindcss/oxide-linux-arm-gnueabihf@4.0.9, npm/@tailwindcss/oxide-freebsd-x64@4.0.9, npm/@tailwindcss/oxide-linux-arm64-musl@4.0.9, npm/@tailwindcss/oxide-linux-arm64-gnu@4.0.9, npm/@tailwindcss/oxide-android-arm64@4.0.9, npm/@tailwindcss/oxide-linux-x64-gnu@4.0.9, npm/@tailwindcss/oxide-linux-x64-musl@4.0.9, npm/@tailwindcss/oxide-win32-x64-msvc@4.0.9, npm/@tailwindcss/oxide-darwin-arm64@4.0.9, npm/@tailwindcss/oxide-win32-arm64-msvc@4.0.9, npm/@tailwindcss/oxide-darwin-x64@4.0.9, npm/@tailwindcss/vite@4.0.9, npm/@types/babel__core@7.20.5, npm/hasown@2.0.2, npm/has-symbols@1.1.0, npm/side-channel@1.1.0, npm/get-intrinsic@1.2.7, npm/object-inspect@1.13.4

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

src/interactive-ui.ts

cryptodev-2s · 2025-02-20T22:43:02Z

@SocketSecurity ignore-all

@SocketSecurity ignore npm/methods@1.1.2
@SocketSecurity ignore npm/raw-body@2.5.2
@SocketSecurity ignore npm/encodeurl@2.0.0
@SocketSecurity ignore npm/body-parser@1.20.3
@SocketSecurity ignore npm/send@0.19.0
@SocketSecurity ignore npm/express@4.21.2

src/ui/App.tsx

mcmire

This looks pretty good! I had some minor suggestions on various things I noticed, but I'm pretty happy with this.

I noticed that creating the release branch took more time than expected, but maybe that's how it's always been. Maybe something we can look at in a future PR.

src/dirname.ts

src/interactive-ui.ts

src/main.test.ts

src/ui/PackageItem.tsx

src/ui/App.tsx

src/ui/PackageItem.tsx

src/ui/App.tsx

src/ui.ts

src/ui/metamask-fox.svg

src/ui/style.css

src/ui/PackageItem.tsx

src/ui/App.tsx

src/release-specification.ts

src/ui/ErrorMessage.tsx

src/ui/App.tsx

…i-beta

socket-security · 2025-03-04T17:26:05Z

Report too large to display inline

View full report↗︎

mcmire

Looks good to me! 🎉🎉

cryptodev-2s requested a review from a team as a code owner February 20, 2025 15:37

cryptodev-2s self-assigned this Feb 20, 2025

cryptodev-2s added the team-core-platform label Feb 20, 2025

cryptodev-2s requested a review from mcmire February 20, 2025 15:37

github-advanced-security bot found potential problems Feb 20, 2025

View reviewed changes

src/interactive-ui.ts Fixed Show fixed Hide fixed

cryptodev-2s force-pushed the cryptodev2s/release-ui-beta branch from f5dc2c7 to 3251623 Compare February 20, 2025 17:27

feat: release UI beta

2385628

cryptodev-2s force-pushed the cryptodev2s/release-ui-beta branch from 3251623 to 2385628 Compare February 20, 2025 19:46

fix: import.meta usage with jest

2d39416

Mrtenz reviewed Feb 21, 2025

View reviewed changes

src/ui/App.tsx Show resolved Hide resolved

cryptodev-2s added 2 commits February 21, 2025 14:15

feat: refactor components

85274c8

feat: multi package selection

c91cc49

mcmire reviewed Feb 25, 2025

View reviewed changes

address feedback

8c3ce77

github-advanced-security bot found potential problems Feb 25, 2025

View reviewed changes

src/ui.ts Fixed Show fixed Hide fixed

cryptodev-2s added 4 commits February 25, 2025 18:23

refactor: add RELEASE_TYPE_OPTIONS

6d01b81

fix: bulk ops selection

7a48c30

fix: bulk ops styling

e9b4c10

feat: auto open release ui

c2642f8

cryptodev-2s requested review from Mrtenz and mcmire February 25, 2025 23:54

cryptodev-2s added 4 commits February 25, 2025 18:59

fix: ignore ui types from coverage

d936785

chore: build ui with vite

edbfa01

fix: use local favicon

69b222a

fix: move react to dev deps

ca3f0a2

mcmire reviewed Mar 3, 2025

View reviewed changes

src/ui/metamask-fox.svg Outdated Show resolved Hide resolved

src/ui/style.css Outdated Show resolved Hide resolved

src/ui/PackageItem.tsx Show resolved Hide resolved

src/ui/App.tsx Show resolved Hide resolved

mcmire reviewed Mar 3, 2025

View reviewed changes

src/release-specification.ts Outdated Show resolved Hide resolved

mcmire reviewed Mar 3, 2025

View reviewed changes

src/ui/ErrorMessage.tsx Outdated Show resolved Hide resolved

src/ui/App.tsx Outdated Show resolved Hide resolved

Apply PR feedback

0d1822c

cryptodev-2s requested a review from mcmire March 4, 2025 15:56

cryptodev-2s added 3 commits March 4, 2025 17:06

fix: rollback missing dependents change regarding dependencies

46009e9

fix: update dependents description

79978cf

Merge remote-tracking branch 'origin/main' into cryptodev2s/release-u…

b6d9b9f

…i-beta

mcmire approved these changes Mar 4, 2025

View reviewed changes

cryptodev-2s merged commit 44404c3 into main Mar 4, 2025
15 checks passed

cryptodev-2s deleted the cryptodev2s/release-ui-beta branch March 4, 2025 19:00

Uh oh!

Conversation

cryptodev-2s commented Feb 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

The Release UI Beta

Uh oh!

socket-security bot commented Feb 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next steps

Uh oh!

Uh oh!

cryptodev-2s commented Feb 20, 2025

Uh oh!

Uh oh!

mcmire left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

socket-security bot commented Mar 4, 2025

Uh oh!

mcmire left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cryptodev-2s commented Feb 20, 2025 •

edited

Loading

socket-security bot commented Feb 20, 2025 •

edited

Loading