feat: ctrl utils add info chains no native token#8336
Merged
Conversation
f8a0636 to
ea040d7
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
ea040d7 to
51571fe
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Tempo asset-controller PR uses as
CHAIN_IDS_TO_SKIP_NATIVE_TOKENconstant in two different controllers.This PR would allow to not have to maintain
CHAIN_IDS_TO_SKIP_NATIVE_TOKENin both controllers and use a commonCHAIN_IDS_WITH_NO_NATIVE_TOKENinstead, for easier maintenance.References
Checklist
Note
Low Risk
Low risk: adds a new exported constant and updates the export surface/tests, with no behavioral changes unless consumers opt in to using it.
Overview
Adds
CHAIN_IDS_WITH_NO_NATIVE_TOKENto@metamask/controller-utils, initially listing Tempo mainnet/testnet CAIP-2 chain IDs for consumers to treat as no-native-token chains.Updates the package public exports and snapshot test to include the new constant, and documents it in the
controller-utilschangelog.Written by Cursor Bugbot for commit 51571fe. This will update automatically on new commits. Configure here.