feat(ramps): update countries endpoint to v2 and add amount fields #7645
+40
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t fields - Add getApiPath helper function for versioned API paths (defaults to v2) - Update getCountries endpoint to use v2/regions/countries - Keep getGeolocation, getEligibility, and getTokens on v1 (no version prefix) - Add defaultAmount and quickAmounts fields to Country type - Update test mocks to use new v2 endpoint path
2d1566e to
8a54c2f
Compare
wachunei
reviewed
Jan 16, 2026
| const textResponse = await this.#request<string>( | ||
| RampsApiService.Orders, | ||
| 'geolocation', | ||
| getApiPath('geolocation', ''), |
Member
There was a problem hiding this comment.
if version is optional then don't pass an empty string
Suggested change
| getApiPath('geolocation', ''), | |
| getApiPath('geolocation'), |
wachunei
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The ramps controller was using the legacy
/regions/countriesendpoint. The backend has introduced a new v2 endpoint at/v2/regions/countriesthat returns additional fields for better UX around amount selection.This PR:
getCountriesendpoint path from/regions/countriesto/v2/regions/countriesdefaultAmountandquickAmountsfields to theCountrytype to match the new backend response shape (RegionV2interface)References
Checklist
Note
Moves countries fetch to the v2 cache API and aligns types for improved amount-selection UX.
RampsService#getCountriesto requestv2/regions/countriesviagetApiPath()(v2 default)CountrywithdefaultAmountandquickAmounts/v2/regions/countriesand updated error stringsCHANGELOG.mdWritten by Cursor Bugbot for commit 2f4bc53. This will update automatically on new commits. Configure here.