-
-
Notifications
You must be signed in to change notification settings - Fork 268
Release/752.0.0 #7642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/752.0.0 #7642
Conversation
f56d6b9 to
2000f45
Compare
5af991f to
79edaa6
Compare
79edaa6 to
2f7b375
Compare
|
|
||
| ### Added | ||
|
|
||
| - Add `nativeAssetIdentifiers` state property that maps CAIP-2 chain IDs to CAIP-19-like native asset identifiers (e.g., `eip155:1/slip44:60`) ([#7609](https://github.com/MetaMask/core/pull/7609)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like a change is missing from this changelog:
| - Add `nativeAssetIdentifiers` state property that maps CAIP-2 chain IDs to CAIP-19-like native asset identifiers (e.g., `eip155:1/slip44:60`) ([#7609](https://github.com/MetaMask/core/pull/7609)) | |
| - Add `nativeAssetIdentifiers` state property that maps CAIP-2 chain IDs to CAIP-19-like native asset identifiers (e.g., `eip155:1/slip44:60`) ([#7609](https://github.com/MetaMask/core/pull/7609)) | |
| - Add `initNativeAssetIdentifiers` method to populate `nativeAssetIdentifiers` state property ([#7609](https://github.com/MetaMask/core/pull/7609)) | |
| - This is designed to be called during controller initialization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed here 623418c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However I don't see in the PR 7609
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or, it must had been added there on that PR, I see
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah sorry, I meant that it wasn't present in the original PR.
mcmire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Explanation
References
Checklist
Note
Release scope
@metamask/connectivity-controller(0.1.0) and upgrades@metamask/network-controllerto29.0.0(now depends on ConnectivityController)@metamask/json-rpc-engine10.2.1and@metamask/eth-block-tracker15.0.1transaction-controller62.9.2,gas-fee-controller26.0.2,polling-controller16.0.2,signature-controller39.0.1assets-controllers95.3.0,bridge-controller64.5.1,bridge-status-controller64.4.3,transaction-pay-controller11.0.2,user-operation-controller41.0.2,multichain-network-controller3.0.2,selected-network-controller26.0.2)accounts-controller35.0.2and updates related packages/changelogs andyarn.lockWritten by Cursor Bugbot for commit 1014302. This will update automatically on new commits. Configure here.