chore: make networkClientId mandatory field in assetsContractController#5941
Open
sahar-fehri wants to merge 10 commits intomainfrom
Open
chore: make networkClientId mandatory field in assetsContractController#5941sahar-fehri wants to merge 10 commits intomainfrom
sahar-fehri wants to merge 10 commits intomainfrom
Conversation
4 tasks
b9477f0 to
5de828d
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
…ts-contract-controller
…ts-contract-controller
Prithpal-Sooriya
approved these changes
Jun 10, 2025
Contributor
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
salimtb
approved these changes
Jun 10, 2025
Contributor
salimtb
left a comment
There was a problem hiding this comment.
preview build tested and approved
…ts-contract-controller
Contributor
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
PR to make
networkClientIdmandatory inAssetsContractController.TEST DRIVE PRs:
References
Changelog
Checklist