Skip to content

fix: assert is unlocked after acquiring the mutex#5757

Draft
mikesposito wants to merge 1 commit into
mainfrom
mikesposito/fix/assert-unlocked-after-mutex
Draft

fix: assert is unlocked after acquiring the mutex#5757
mikesposito wants to merge 1 commit into
mainfrom
mikesposito/fix/assert-unlocked-after-mutex

Conversation

@mikesposito

Copy link
Copy Markdown
Member

Explanation

The #assertIsUnlocked assertion is placed in all controller method as first line. Though for methods that mutate the controller state and update the vault (through #persistOrRollback) or that acquire the controller mutex through #withRollback, the assertion should come after the mutex has been acquired.

References

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant