Merged
Conversation
7c711aa to
9a5238f
Compare
Contributor
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Base automatically changed from
add-endpoint-url-to-rpc-service-callbacks
to
main
January 31, 2025 18:04
We want to update the `fetch` middleware in `eth-json-rpc-middleware` and the Infura middleware in `eth-json-rpc-infura` to automatically fail over to alternate RPC endpoints when the desired endpoint is down. To do this, we need a way to string together a collection of RPC services, where the first service represents the primary endpoint, the second service is failover for the first, the third service is a failover for the second, etc. This composite object should conform to the same interface as an RPC service so consumers do not have to care whether they are working with a single endpoint or a chain of them. Also expose `AbstractRpcService` so that we can make use of it in the middleware packages.
269b72b to
aded418
Compare
mcmire
commented
Feb 3, 2025
cryptodev-2s
reviewed
Feb 3, 2025
Co-authored-by: cryptodev-2s <109512101+cryptodev-2s@users.noreply.github.com>
cryptodev-2s
reviewed
Feb 3, 2025
cryptodev-2s
reviewed
Feb 3, 2025
cryptodev-2s
previously approved these changes
Feb 3, 2025
Contributor
cryptodev-2s
left a comment
There was a problem hiding this comment.
LGTM! I left some minor suggestions
Co-authored-by: cryptodev-2s <109512101+cryptodev-2s@users.noreply.github.com>
Co-authored-by: cryptodev-2s <109512101+cryptodev-2s@users.noreply.github.com>
cryptodev-2s
approved these changes
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
We want to update the
fetchmiddleware ineth-json-rpc-middlewareand the Infura middleware ineth-json-rpc-infurato automatically fail over to alternate RPC endpoints when the desired endpoint is down. To do this, we need a way to string together a collection of RPC services, where the first service represents the primary endpoint, the second service is the failover for the first, the third service is a failover for the second, etc. This composite object should conform to the same interface as an RPC service so consumers do not have to care whether they are working with a single endpoint or a chain of them.References
Closes #5222.
Changelog
(Updated in PR.)
Checklist