Merged
Conversation
mcmire
commented
Jan 16, 2025
31debed to
2b6e317
Compare
8ae2602 to
540bf4b
Compare
This commit adds an RPC service class that will ultimately be used inside of middleware to make JSON-RPC requests to an RPC endpoint. It makes uses of `createServicePolicy`, added in a previous commit, to encapsulate the request code using the retry and circuit breaker policies. As this service class is designed to replace large parts of the fetch and Infura middleware, it customizes the service policy so that the request will be retried only when the network is perceived to be "down". This occurs when: - The `fetch` call throws a "Failed to fetch" error (or something similar to it; see code for the full list of variations) - The `fetch` call throws an ETIMEDOUT or ECONNRESET error - The response status is 503 or 504 - The response body is invalid JSON In contrast, the network is not perceived to be "down" if: - The `fetch` call throws an unexpected error (e.g. if the request options are invalid) - The response status is not 2xx, but is also not 503 or 504 - The response body is an unsuccessful JSON-RPC response - The response body is a successful, but empty, JSON-RPC response
540bf4b to
a5d7141
Compare
mcmire
commented
Jan 27, 2025
Contributor
Author
There was a problem hiding this comment.
You may wish to cross-reference the logic in this file with:
Co-authored-by: cryptodev-2s <109512101+cryptodev-2s@users.noreply.github.com>
Co-authored-by: cryptodev-2s <109512101+cryptodev-2s@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This commit adds an RPC service class that will ultimately be used inside of middleware to make JSON-RPC requests to an RPC endpoint. It makes uses of
createServicePolicy, added in a previous commit, to encapsulate the request code using the retry and circuit breaker policies. As this service class is designed to replace large parts of the fetch and Infura middleware, it customizes the service policy so that the request will be retried only when the network is perceived to be "down". This occurs when:fetchcall throws a "Failed to fetch" error (or something similar to it; see code for the full list of variations)fetchcall throws an ETIMEDOUT or ECONNRESET errorIn contrast, the network is not perceived to be "down" if:
fetchcall throws an unexpected error (e.g. if the request options are invalid)References
Closes #4990.
Changelog
(N/A; internal change only)
Checklist