Skip to content

chore: Move BigNumber.js to dependencies#4873

Merged
FrederikBolding merged 1 commit intomainfrom
fb/move-bignumber.js-to-deps
Oct 30, 2024
Merged

chore: Move BigNumber.js to dependencies#4873
FrederikBolding merged 1 commit intomainfrom
fb/move-bignumber.js-to-deps

Conversation

@FrederikBolding
Copy link
Copy Markdown
Member

Explanation

Since bignumber.js is used for typing in controller-utils, it should likely be a dependency to prevent issues when building with TS downstream.

There is probably a larger conversation to have here about when to use types as devDeps and when to use them as deps, but in our architecture today we rely heavily on all types to be included as dependencies. This causes a lot of potentially avoidable dependency management.

Changelog

@metamask/controller-utils

  • Fixed: Move bignumber.js to dependencies

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@FrederikBolding FrederikBolding requested a review from a team as a code owner October 30, 2024 08:45
@FrederikBolding FrederikBolding merged commit 018261d into main Oct 30, 2024
@FrederikBolding FrederikBolding deleted the fb/move-bignumber.js-to-deps branch October 30, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants