Skip to content

fix: Add validation to ensure gas fields are valid hexadecimal#4854

Merged
vinistevam merged 3 commits intomainfrom
fix/add-is-valid-hex-gas-fields
Nov 4, 2024
Merged

fix: Add validation to ensure gas fields are valid hexadecimal#4854
vinistevam merged 3 commits intomainfrom
fix/add-is-valid-hex-gas-fields

Conversation

@vinistevam
Copy link
Copy Markdown
Contributor

@vinistevam vinistevam commented Oct 28, 2024 •
edited
Loading

Explanation

This PR aims to add validation to ensure gas fields are valid hexadecimal.

References

fixes MetaMask/metamask-mobile#11774

Changelog

@metamask/transaction-controller

  • Added: Validation for gas values to ensure they are valid hexadecimal

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@vinistevam vinistevam requested a review from a team as a code owner October 28, 2024 14:32
@vinistevam
Copy link
Copy Markdown
Contributor Author

vinistevam commented Oct 29, 2024

@metamaskbot publish-preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 29, 2024

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "18.2.2-preview-374ec2c3",
  "@metamask-previews/address-book-controller": "6.0.1-preview-374ec2c3",
  "@metamask-previews/announcement-controller": "7.0.1-preview-374ec2c3",
  "@metamask-previews/approval-controller": "7.1.0-preview-374ec2c3",
  "@metamask-previews/assets-controllers": "39.0.0-preview-374ec2c3",
  "@metamask-previews/base-controller": "7.0.1-preview-374ec2c3",
  "@metamask-previews/build-utils": "3.0.1-preview-374ec2c3",
  "@metamask-previews/chain-controller": "0.1.3-preview-374ec2c3",
  "@metamask-previews/composable-controller": "9.0.1-preview-374ec2c3",
  "@metamask-previews/controller-utils": "11.4.0-preview-374ec2c3",
  "@metamask-previews/ens-controller": "14.0.1-preview-374ec2c3",
  "@metamask-previews/eth-json-rpc-provider": "4.1.5-preview-374ec2c3",
  "@metamask-previews/gas-fee-controller": "21.0.0-preview-374ec2c3",
  "@metamask-previews/json-rpc-engine": "10.0.0-preview-374ec2c3",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.4-preview-374ec2c3",
  "@metamask-previews/keyring-controller": "17.3.0-preview-374ec2c3",
  "@metamask-previews/logging-controller": "6.0.1-preview-374ec2c3",
  "@metamask-previews/message-manager": "11.0.0-preview-374ec2c3",
  "@metamask-previews/multichain": "0.0.0-preview-374ec2c3",
  "@metamask-previews/name-controller": "8.0.1-preview-374ec2c3",
  "@metamask-previews/network-controller": "22.0.0-preview-374ec2c3",
  "@metamask-previews/notification-controller": "7.0.0-preview-374ec2c3",
  "@metamask-previews/notification-services-controller": "0.12.0-preview-374ec2c3",
  "@metamask-previews/permission-controller": "11.0.2-preview-374ec2c3",
  "@metamask-previews/permission-log-controller": "3.0.1-preview-374ec2c3",
  "@metamask-previews/phishing-controller": "12.2.0-preview-374ec2c3",
  "@metamask-previews/polling-controller": "11.0.0-preview-374ec2c3",
  "@metamask-previews/preferences-controller": "13.1.0-preview-374ec2c3",
  "@metamask-previews/profile-sync-controller": "0.9.7-preview-374ec2c3",
  "@metamask-previews/queued-request-controller": "5.1.0-preview-374ec2c3",
  "@metamask-previews/rate-limit-controller": "6.0.1-preview-374ec2c3",
  "@metamask-previews/selected-network-controller": "18.0.2-preview-374ec2c3",
  "@metamask-previews/signature-controller": "20.1.0-preview-374ec2c3",
  "@metamask-previews/transaction-controller": "37.3.0-preview-374ec2c3",
  "@metamask-previews/user-operation-controller": "16.0.0-preview-374ec2c3"
}

@vinistevam
Copy link
Copy Markdown
Contributor Author

vinistevam commented Oct 29, 2024

Clients PRs:

@vinistevam vinistevam merged commit 506071e into main Nov 4, 2024
@vinistevam vinistevam deleted the fix/add-is-valid-hex-gas-fields branch November 4, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

Assignees

No one assigned

Labels

team-confirmations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Sentry] Error: [number-to-bn] while converting number "0x28.834701826" to BN.js instance, error: invalid number ...

2 participants

@vinistevam @matthewwalsh0