Skip to content

Add default snap dialog to ApprovalType#4630

Merged
ritave merged 1 commit intomainfrom
ritave/approval-type
Aug 21, 2024
Merged

Add default snap dialog to ApprovalType#4630
ritave merged 1 commit intomainfrom
ritave/approval-type

Conversation

@ritave
Copy link
Copy Markdown
Contributor

@ritave ritave commented Aug 21, 2024

Explanation

This is a part of MetaMask/metamask-extension#26304 (comment), we upstream the constant to the core monorepo and after, we should update the metamask-extension on next release.

References

Part of #4598

Changelog

@metamask/controller-utils

  • ADDED: Added default snap dialog constant to ApprovalType.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

Comment thread packages/controller-utils/src/constants.ts Outdated
@ritave ritave force-pushed the ritave/approval-type branch from e5b4dcb to e0234fc Compare August 21, 2024 11:54
@ritave ritave merged commit 596c42b into main Aug 21, 2024
@ritave ritave deleted the ritave/approval-type branch August 21, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants