Conversation
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
left a comment
There was a problem hiding this comment.
LGTM! One non-blocking suggestion
|
|
||
| ### Fixed | ||
|
|
||
| - transaction-controller – approveTransaction was throwing away raw signed transaction ([#4255](https://github.com/MetaMask/core/pull/4255)) |
There was a problem hiding this comment.
Nit: The change entry you included in the PR description here seems better suited. The "transaction-controller - " part here especially seems out-of-place (this whole changelog is transaction controller specific already).
I've added my own attempt at briefly summarizing this, then included your change entry as a sub bullet. Let me know what you think!
| - transaction-controller – approveTransaction was throwing away raw signed transaction ([#4255](https://github.com/MetaMask/core/pull/4255)) | |
| - Prevent pending transaction from being inaccurately identified as failed ([#4255](https://github.com/MetaMask/core/pull/4255)) | |
| - When resubmitting a pending transaction, if an 'already seen' error is caught (which indicates that the transaction is still pending in the mempool), we now ignore the error instead of failing the transaction |
There was a problem hiding this comment.
I had an old description of the fix in the PR. I updated the description of the real fix in the PR and copied it here.
Found a few missing change entries - will leave an updated review in a moment
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
Explanation
Patch release of TransactionController to fix rawTx being dropped from Tx Metadata #4255.
References