Skip to content

feat: implement OptimismLayer1GasFeeFlow#4055

Merged
OGPoyraz merged 21 commits intomainfrom
1944-implement-layer-1-gas-fee-flow-for-optimism-3
Mar 27, 2024
Merged

feat: implement OptimismLayer1GasFeeFlow#4055
OGPoyraz merged 21 commits intomainfrom
1944-implement-layer-1-gas-fee-flow-for-optimism-3

Conversation

@OGPoyraz
Copy link
Copy Markdown
Member

@OGPoyraz OGPoyraz commented Mar 14, 2024

Explanation

This PR implements and activates OptimisimLayer1GasFeeFlow for Optimisim based transactions.

References

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1944

Changelog

@metamask/transaction-controller

  • ADDED: Implement and activate OptimisimLayer1GasFeeFlow for Optimisim based transactions

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@OGPoyraz
Copy link
Copy Markdown
Member Author

OGPoyraz commented Mar 14, 2024

@metamaskbot publish-preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 14, 2024

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "12.0.1-preview-d4ae797",
  "@metamask-previews/address-book-controller": "4.0.1-preview-d4ae797",
  "@metamask-previews/announcement-controller": "6.0.1-preview-d4ae797",
  "@metamask-previews/approval-controller": "6.0.1-preview-d4ae797",
  "@metamask-previews/assets-controllers": "27.0.1-preview-d4ae797",
  "@metamask-previews/base-controller": "5.0.1-preview-d4ae797",
  "@metamask-previews/build-utils": "2.0.1-preview-d4ae797",
  "@metamask-previews/composable-controller": "6.0.1-preview-d4ae797",
  "@metamask-previews/controller-utils": "9.0.1-preview-d4ae797",
  "@metamask-previews/ens-controller": "10.0.1-preview-d4ae797",
  "@metamask-previews/eth-json-rpc-provider": "3.0.1-preview-d4ae797",
  "@metamask-previews/gas-fee-controller": "14.0.1-preview-d4ae797",
  "@metamask-previews/json-rpc-engine": "8.0.1-preview-d4ae797",
  "@metamask-previews/json-rpc-middleware-stream": "7.0.1-preview-d4ae797",
  "@metamask-previews/keyring-controller": "14.0.1-preview-d4ae797",
  "@metamask-previews/logging-controller": "3.0.1-preview-d4ae797",
  "@metamask-previews/message-manager": "8.0.1-preview-d4ae797",
  "@metamask-previews/name-controller": "6.0.1-preview-d4ae797",
  "@metamask-previews/network-controller": "18.0.1-preview-d4ae797",
  "@metamask-previews/notification-controller": "5.0.1-preview-d4ae797",
  "@metamask-previews/permission-controller": "9.0.1-preview-d4ae797",
  "@metamask-previews/permission-log-controller": "2.0.1-preview-d4ae797",
  "@metamask-previews/phishing-controller": "9.0.1-preview-d4ae797",
  "@metamask-previews/polling-controller": "6.0.1-preview-d4ae797",
  "@metamask-previews/preferences-controller": "9.0.1-preview-d4ae797",
  "@metamask-previews/queued-request-controller": "0.6.1-preview-d4ae797",
  "@metamask-previews/rate-limit-controller": "5.0.1-preview-d4ae797",
  "@metamask-previews/selected-network-controller": "10.0.1-preview-d4ae797",
  "@metamask-previews/signature-controller": "14.0.1-preview-d4ae797",
  "@metamask-previews/transaction-controller": "25.1.0-preview-d4ae797",
  "@metamask-previews/user-operation-controller": "6.0.1-preview-d4ae797"
}

@OGPoyraz OGPoyraz mentioned this pull request Mar 14, 2024
Closed
13 tasks
@OGPoyraz
Copy link
Copy Markdown
Member Author

OGPoyraz commented Mar 15, 2024

@metamaskbot publish-preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 15, 2024

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "12.0.1-preview-da8ff5ef",
  "@metamask-previews/address-book-controller": "4.0.1-preview-da8ff5ef",
  "@metamask-previews/announcement-controller": "6.0.1-preview-da8ff5ef",
  "@metamask-previews/approval-controller": "6.0.1-preview-da8ff5ef",
  "@metamask-previews/assets-controllers": "27.0.1-preview-da8ff5ef",
  "@metamask-previews/base-controller": "5.0.1-preview-da8ff5ef",
  "@metamask-previews/build-utils": "2.0.1-preview-da8ff5ef",
  "@metamask-previews/composable-controller": "6.0.1-preview-da8ff5ef",
  "@metamask-previews/controller-utils": "9.0.1-preview-da8ff5ef",
  "@metamask-previews/ens-controller": "10.0.1-preview-da8ff5ef",
  "@metamask-previews/eth-json-rpc-provider": "3.0.1-preview-da8ff5ef",
  "@metamask-previews/gas-fee-controller": "14.0.1-preview-da8ff5ef",
  "@metamask-previews/json-rpc-engine": "8.0.1-preview-da8ff5ef",
  "@metamask-previews/json-rpc-middleware-stream": "7.0.1-preview-da8ff5ef",
  "@metamask-previews/keyring-controller": "14.0.1-preview-da8ff5ef",
  "@metamask-previews/logging-controller": "3.0.1-preview-da8ff5ef",
  "@metamask-previews/message-manager": "8.0.1-preview-da8ff5ef",
  "@metamask-previews/name-controller": "6.0.1-preview-da8ff5ef",
  "@metamask-previews/network-controller": "18.0.1-preview-da8ff5ef",
  "@metamask-previews/notification-controller": "5.0.1-preview-da8ff5ef",
  "@metamask-previews/permission-controller": "9.0.1-preview-da8ff5ef",
  "@metamask-previews/permission-log-controller": "2.0.1-preview-da8ff5ef",
  "@metamask-previews/phishing-controller": "9.0.1-preview-da8ff5ef",
  "@metamask-previews/polling-controller": "6.0.1-preview-da8ff5ef",
  "@metamask-previews/preferences-controller": "9.0.1-preview-da8ff5ef",
  "@metamask-previews/queued-request-controller": "0.6.1-preview-da8ff5ef",
  "@metamask-previews/rate-limit-controller": "5.0.1-preview-da8ff5ef",
  "@metamask-previews/selected-network-controller": "10.0.1-preview-da8ff5ef",
  "@metamask-previews/signature-controller": "14.0.1-preview-da8ff5ef",
  "@metamask-previews/transaction-controller": "25.1.0-preview-da8ff5ef",
  "@metamask-previews/user-operation-controller": "6.0.1-preview-da8ff5ef"
}

@OGPoyraz OGPoyraz force-pushed the 1944-implement-layer-1-gas-fee-flow-for-optimism-3 branch from 427b701 to 23582df Compare March 15, 2024 11:54
@OGPoyraz OGPoyraz marked this pull request as ready for review March 15, 2024 13:35
@OGPoyraz OGPoyraz requested a review from a team as a code owner March 15, 2024 13:35
@OGPoyraz OGPoyraz changed the title Implement OptimisimLayer1GasFeeFlow Implement OptimismLayer1GasFeeFlow Mar 15, 2024
@OGPoyraz OGPoyraz changed the title Implement OptimismLayer1GasFeeFlow feat: implement OptimismLayer1GasFeeFlow Mar 18, 2024
@OGPoyraz OGPoyraz added the team-confirmations-system DEPRECATED: please use "team-confirmations" label instead label Mar 18, 2024
@MetaMask MetaMask deleted a comment from github-actions bot Mar 19, 2024
@MetaMask MetaMask deleted a comment from github-actions bot Mar 19, 2024
@OGPoyraz
Copy link
Copy Markdown
Member Author

OGPoyraz commented Mar 19, 2024

@metamaskbot publish-preview

@OGPoyraz
Copy link
Copy Markdown
Member Author

OGPoyraz commented Mar 19, 2024

@metamaskbot publish-preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 19, 2024

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "12.0.1-preview-68beceb0",
  "@metamask-previews/address-book-controller": "4.0.1-preview-68beceb0",
  "@metamask-previews/announcement-controller": "6.0.1-preview-68beceb0",
  "@metamask-previews/approval-controller": "6.0.1-preview-68beceb0",
  "@metamask-previews/assets-controllers": "27.1.0-preview-68beceb0",
  "@metamask-previews/base-controller": "5.0.1-preview-68beceb0",
  "@metamask-previews/build-utils": "2.0.1-preview-68beceb0",
  "@metamask-previews/composable-controller": "6.0.1-preview-68beceb0",
  "@metamask-previews/controller-utils": "9.0.2-preview-68beceb0",
  "@metamask-previews/ens-controller": "10.0.1-preview-68beceb0",
  "@metamask-previews/eth-json-rpc-provider": "3.0.1-preview-68beceb0",
  "@metamask-previews/gas-fee-controller": "14.0.1-preview-68beceb0",
  "@metamask-previews/json-rpc-engine": "8.0.1-preview-68beceb0",
  "@metamask-previews/json-rpc-middleware-stream": "7.0.1-preview-68beceb0",
  "@metamask-previews/keyring-controller": "14.0.1-preview-68beceb0",
  "@metamask-previews/logging-controller": "3.0.1-preview-68beceb0",
  "@metamask-previews/message-manager": "8.0.1-preview-68beceb0",
  "@metamask-previews/name-controller": "6.0.1-preview-68beceb0",
  "@metamask-previews/network-controller": "18.0.1-preview-68beceb0",
  "@metamask-previews/notification-controller": "5.0.1-preview-68beceb0",
  "@metamask-previews/permission-controller": "9.0.2-preview-68beceb0",
  "@metamask-previews/permission-log-controller": "2.0.1-preview-68beceb0",
  "@metamask-previews/phishing-controller": "9.0.1-preview-68beceb0",
  "@metamask-previews/polling-controller": "6.0.1-preview-68beceb0",
  "@metamask-previews/preferences-controller": "9.0.1-preview-68beceb0",
  "@metamask-previews/queued-request-controller": "0.6.1-preview-68beceb0",
  "@metamask-previews/rate-limit-controller": "5.0.1-preview-68beceb0",
  "@metamask-previews/selected-network-controller": "10.0.1-preview-68beceb0",
  "@metamask-previews/signature-controller": "14.0.1-preview-68beceb0",
  "@metamask-previews/transaction-controller": "25.1.0-preview-68beceb0",
  "@metamask-previews/user-operation-controller": "6.0.1-preview-68beceb0"
}

@OGPoyraz OGPoyraz mentioned this pull request Mar 19, 2024
Merged
12 tasks
matthewwalsh0
matthewwalsh0 reviewed Mar 26, 2024
View reviewed changes
matthewwalsh0
matthewwalsh0 reviewed Mar 27, 2024
View reviewed changes
@OGPoyraz OGPoyraz merged commit add19e7 into main Mar 27, 2024
@OGPoyraz OGPoyraz deleted the 1944-implement-layer-1-gas-fee-flow-for-optimism-3 branch March 27, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

@vinistevam vinistevam vinistevam approved these changes

Assignees

No one assigned

Labels

team-confirmations-system DEPRECATED: please use "team-confirmations" label instead

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@OGPoyraz @matthewwalsh0 @vinistevam